GoogleCloudPlatform / bank-of-anthos

Retail banking sample application showcasing Kubernetes and Google Cloud
https://cymbal-bank.fsi.cymbal.dev
Apache License 2.0
984 stars 580 forks source link

Pylint - switch to Google style guide #465

Open askmeegs opened 3 years ago

askmeegs commented 3 years ago

Current we have a pylint file - https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/master/.pylintrc - that ignores certain pylint errors in the Python service source code.

Let's try to remove most of these ignores to get the most out of linting, using Google's python style guide as source material for what messages might be okay to ignore.

bourgeoisor commented 2 years ago

This is still planned in the long term.

bourgeoisor commented 2 years ago

Still want to do this. @glasnt also suggested considering black as an alternative to pylint.

glasnt commented 2 years ago

python-docs-samples uses flake8 (to conform to the styleguide) and black is optional (docs). The flake8 config in noxfile.py should be useful here.

parthea commented 1 year ago

pyink is a fork of black under the Google org and may be an alternate to black https://github.com/google/pyink

parthea commented 1 year ago

isort tool can also be used to sort imports https://github.com/PyCQA/isort

minherz commented 1 year ago

The work on this item is postponed to Q4'24