GoogleCloudPlatform / berglas

A tool for managing secrets on Google Cloud
https://cloud.google.com/secret-manager
Apache License 2.0
1.24k stars 96 forks source link

Generation/version missing in errorhandling #104

Closed leo-baltus closed 4 years ago

leo-baltus commented 4 years ago

While testing I stumbled on this:

RW_PASSWD=berglas://berglas-store/foo#582554393671996 go run my/main.go
2020/02/27 16:36:10 failed to access secret berglas-store/foo: failed to access secret: secret does not exist

So it is not reporting the generation or version which can be very helpful when debugging. https://github.com/GoogleCloudPlatform/berglas/blob/f168b3ab80a04f3f030eedf09173b00d5afd6425/pkg/berglas/resolver.go#L72

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

sethvargo commented 4 years ago

Fixed as part of https://github.com/GoogleCloudPlatform/berglas/commit/a1952ecb6fb282b33871ef786b07787ed285d037