GoogleCloudPlatform / bigquery-geo-viz

Visualize Google BigQuery geospatial data using Google Maps Platform APIs
https://bigquerygeoviz.appspot.com/
Apache License 2.0
107 stars 38 forks source link

strokeColor by data value is not working #11

Closed ramiroaznar closed 4 years ago

ramiroaznar commented 4 years ago

I am trying to style my LineStrings by a categorical value from one of my columns. But it looks like the feature is broken, the geometries are only being styled using the first color value.

STR

  1. Query a LineString dataset
  2. Go to STYLE and enable the data-driven option from the strokeColor section
  3. Select a categorical column
  4. Fill it with the proper unique values
  5. Select any color combination

Expected result

LineStrings should be styled by categorical values.

Current Result

bug

Some errors are shown in the console. LineStrings are only plotted using the first color value.

OS and device

Chrome 77 Ubuntu 18

donmccurdy commented 4 years ago

I'm not able to reproduce this – can you share some example data or a query? There may be something about the particular data you're reading that causes the error, but a simple LineString dataset is working fine for me. For example:

SELECT
  ST_GeogFromText("LINESTRING (30 10, 10 30, 40 40)") geo,
  "unsafe" condition;

Screen Shot 2019-10-10 at 10 34 50 AM Screen Shot 2019-10-10 at 10 35 11 AM

ramiroaznar commented 4 years ago

You are right. I have also getting the same result when styling the centroids of my linestrings. I am going to try to clean my data, but it would be great if there were any useful error pointing to the problem. As soon as I find the conflict row value, I will share it here.

donmccurdy commented 4 years ago

Ok – happy to fix this if you can share a query that reproduces the error.

ramiroaznar commented 4 years ago

Hi Don,

Sorry for the lack of response. You can keep it close. I cannot share the data, but it was definitively something related to the values. I do not recall it was null or invalid geometries though. Thanks anyway!

On Wed, 8 Jan 2020 at 19:23, Don McCurdy notifications@github.com wrote:

Ok – happy to fix this if you can share a query that reproduces the error.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/bigquery-geo-viz/issues/11?email_source=notifications&email_token=ABHZMNTRKUZYMSC2H5PD4ITQ4YKYPA5CNFSM4I6QSLRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINP43Y#issuecomment-572194415, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZMNTGKNTTJKJJZ6G67MTQ4YKYPANCNFSM4I6QSLRA .