GoogleCloudPlatform / bigquery-geo-viz

Visualize Google BigQuery geospatial data using Google Maps Platform APIs
https://bigquerygeoviz.appspot.com/
Apache License 2.0
107 stars 38 forks source link

Making the drop down for geometry column to only show geography columns #18

Closed hormati closed 4 years ago

donmccurdy commented 4 years ago

If the user had a text column containing WKT text (which they hadn't given a geography type in BigQuery for whatever reason), they'd be able to select and use it before this change, but not after. Is that OK? Not sure if it would be common from, say, CSV imports.

hormati commented 4 years ago

Is there a good reason that they haven't given it a geography type in BQ?

I think it's best to be strict about these things and enforce the schema as strictly as possible. Otherwise, we will start getting into the business of parsing strings and figuring out what is geography and what is not.

Also, I should note that currently if I select non-geography columns from the drop down, my chrome tab becomes non-responsive.

mentin commented 4 years ago

I think the ability to display any text field was useful in original design, but now we require presence of geography column anyway, when creating a wrapper query. So it is not very useful, as GeoViz cannot be used without a typed geography column.

donmccurdy commented 4 years ago

OK, sounds good. 👍