search

GoogleCloudPlatform / cloud-builders-community

Community-contributed images for Google Cloud Build
https://cloud.google.com/cloud-build/
Apache License 2.0
1.26k stars 858 forks source link

Getting GCE error when trying to use the windows builder #537

Closed nishant-shah-social closed 2 years ago

nishant-shah-social commented 3 years ago

Affected builder image

gcr.io/cloud-builders-community/windows-builder

Expected Behavior

Should be able to use the windows-builder image successfully in google cloud build

Actual Behavior

Getting the below error message specific to GCE :- Starting GCE service in project playground-nishant 2021/10/12 06:35:00 GCE Instances insert call failed: googleapi: Error 400: Invalid value for field 'resource.tags.items[0]': ''. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)', invalid

Steps to Reproduce the Problem

  1. Simply followed the steps mentioned here :- https://github.com/GoogleCloudPlatform/cloud-builders-community/tree/master/windows-builder

Additional Info

I performed these steps from a mac book. Hope it should not be a problem

isarkis commented 2 years ago

@perezd, is the --tags option mandatory? If so, we'll need to update the README.md.

perezd commented 2 years ago

I didn't intend to make it required, does it appear to be? If so we can make it optional.

isarkis commented 2 years ago

Yes, windows-builder throws an error without --tags argument.

perezd commented 2 years ago

OK, that's a mistake. Send a PR to make it optional?

isarkis commented 2 years ago

PTAL https://github.com/GoogleCloudPlatform/cloud-builders-community/pull/544

isarkis commented 2 years ago

Can someone help close this issue, it's been fixed?