search

GoogleCloudPlatform / cloud-builders

Builder images and examples commonly used for Google Cloud Build
https://cloud.google.com/cloud-build/
Apache License 2.0
1.38k stars 590 forks source link

[BUG] gke-deploy / PodDisruptionBudget #840

Open epikjjh opened 2 years ago

epikjjh commented 2 years ago

Failed to use PodDisruptionBudget

Same as #725 . When setting spec: maxUnavailable, the builder can't know the ready state well.

Affected builder image

gcr.io/cloud-builders/gke-deploy (e.g., gcr.io/cloud-builders/docker)

Expected Behavior

Builder should identify that the PodDisruptionBudget is working fine.

Actual Behavior

Even if PodDisruptionBudget is working fine(checked with kubectl), builder identifies this as failure.

Steps to Reproduce the Problem

Use maxUnavailable then apply the gke-deploy-run

Additional Info

At least, we should know maxUnavailable is not supported.

ckopparthi commented 2 months ago

@haroonc I am affected by this bug, do you have any timeline of a fix