GoogleCloudPlatform / cloud-builders

Builder images and examples commonly used for Google Cloud Build
https://cloud.google.com/cloud-build/
Apache License 2.0
1.38k stars 589 forks source link

[FR] Remove mandatory dependence on gsutil #976

Closed chitrangpatel closed 7 months ago

chitrangpatel commented 7 months ago

Detailed Feature Information

Which builder is relevant to this request? gke-deploy

Is your feature request related to a problem? Please describe. When running gke-deploy from an image that has all the k8s configuration files locally, the CLI still errors because it does not have gsutil in its $PATH. gsutil is only required to fetch the config from GCS and to push the config to GCS.

We can use gke-deploy cli and embed in other images that does not need to interact with gcs at all. Yet, it will need to install gsutil on the image which expands such image size by > 2 GB!

Describe the solution you'd like gke-deploy should check if the filename or the output param starts with gs:// and only then use the GCS client. Like it does with gcloud (there by checking the path). https://github.com/GoogleCloudPlatform/cloud-builders/pull/975 has the solution implemented.

chitrangpatel commented 7 months ago

/assign