GoogleCloudPlatform / cloud-code-intellij

Plugin to support the Google Cloud Platform in IntelliJ IDEA - Docs and Issues Repository
Apache License 2.0
319 stars 59 forks source link

[CC Terminals] set PATH not working anymore on windows #3147

Closed mirdones closed 1 year ago

mirdones commented 1 year ago

image

I clicked on my database to connect to it as I always did, it would open a terminal and connect to it. Now I am getting an error related to PATH after updating to the latest plugin version.

Expected Behavior

Connect to CloudSQL

Should use the following command on windows:

$Env:PATH+=

Actual Behavior

set PATH

%PATH%: The term '%PATH%' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Additional Information

ivanporty commented 1 year ago

It looks like the plugin doesn't recognize this terminal as Powershell for some reason and falls back to standard Windows. We'll investigate, thanks for the report!

cedriclevarlet commented 1 year ago

Same issue here. Adding to this, when I swap to the standard terminal instead of powershell I do not get any feedback (it happens for every command executed by the plugin):

image

mirdones commented 1 year ago

The last version that worked is not working with the new pycharm version. please correct this ASAP.

ivanporty commented 1 year ago

Thanks for the report, we are looking to it and will try to get this fixed soon.

ivanporty commented 1 year ago

We do not see an issue with Powershell commands so far. @mirdones > The last version that worked is not working with the new pycharm version. - could you please tell us what version of (a) the plugin (b) PyCharm (c) windows are you using?

mirdones commented 1 year ago

@ivanporty

Any version of the plugin after google-cloud-code-23.5.2-222 has this problem.

To circumvent this I am using google-cloud-code-23.5.2-222 along with pycharm 2023.1.4, which was the last combination that worked.

Steps for reproducing the problem:

1 - Open Google cloud databases in the left:

image

2 - Double click on the database you want to connect

3 - Error occurs on Powershell. On cmd there is no response as @cedriclevarlet also reported.

mirdones commented 1 year ago

@ivanporty do you have any news on the fix for this bug?

ivanporty commented 1 year ago

@mirdones the CMD fix is scheduled for the next release. Sorry for the wait. The powershell is working for us in tests and we are still looking into why we cannot identify it on setups such as yours, and hopefully will add the fix as well.

ivanporty commented 1 year ago

@mirdones @cedriclevarlet we've released CMD fix in 23.9.1, if you want to use it.

peterlin741 commented 1 year ago

There was another fix in 23.10.1. Please reopen if you are still seeing issues.