search

GoogleCloudPlatform / cloud-code-vscode

Cloud Code for Visual Studio Code: Issues, Documentation and more
Other
413 stars 111 forks source link

Notification of breaking api change with v1.92 release of VS Code #920

Closed deepak1556 closed 1 month ago

deepak1556 commented 2 months ago

Hello from the VS Code team 👋

In our next release v1.92, we will update to Electron 30 which includes Node.js 20.14.0. This Node version contains a breaking change, in response to a CVE, which may affect you if you execute .bat or .cmd files on Windows. Based on a simple scan of your extension's source code, you may be impacted by this change. The stable VS Code that contains this update will be released in early August.

Action: please try out your extension on this month's VS Code Insiders on Windows. If you are affected by this change, you will encounter an EINVAL error when you try to spawn a bat/cmd file.

Node.js has added a section on batch file spawning to their documentation. To fix any issues:

  1. Find locations where you call child_process.spawn to execute a batch file on Windows
  2. Add shell: true or shell: process.platform === 'win32' to the options object
  3. If the batch script path may contain spaces, you will also need to wrap the path in quotation marks.

Please let us know if you run into issues or if you need clarification.

Happy coding!

pxFIN commented 1 month ago

Since Visual Studio Code version 1.92 is out this project needs fixing. Any ETA ?

In the meantime before fix also those who see Spawn EINVAL error version 1.91 of VSC still works

davidponder commented 1 month ago

Hello!

Sorry for the late reply here, I was chasing down a few answers. The Insiders release channel will have a fix published by tomorrow morning PST. Our newest production release (2.16.0) will also have the fix and will be available later this week.

To acquire this fix as soon as it's available, please update the setting "cloudcode.updateChannel" to the value "Insiders".

Thank you for your patience!

slde12 commented 1 month ago

This is fixed in the latest version of cloud code vscode 2.16.0