GoogleCloudPlatform / cloud-code-vscode

Cloud Code for Visual Studio Code: Issues, Documentation and more
Other
420 stars 112 forks source link

YAML Validation Conflict when YAML file has "action" in the name #958

Open sspage opened 3 weeks ago

sspage commented 3 weeks ago

Environment: VSCode on multiple platforms; Windows 11, ChromeOS, Mac

Version information

Cloud Code Extension version: v.2.20.0

VSCode version: Version: 1.95.1 (user setup) Commit: 65edc4939843c90c34d61f4ce11704f09d3e5cb6 Date: 2024-10-31T05:14:54.222Z Electron: 32.2.1 ElectronBuildId: 10427718 Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Windows_NT arm64 10.0.26120

OS: Windows 11

Cloud SDK: N/A

Skaffold: N/A

Kubectl:
Kubernetes extension by Microsoft v1.3.18 Not installed otherwise

YAML Extension: YAML by Redhat v1.15.0

Description: YAML with Open AI Spec shows validation errors throughout despite being valid YAML. Tried adding this to settings.json:

"yaml.schemas": {

    "https://spec.openapis.org/oas/3.1/schema/2021-09-28": "*.yaml"
},

File can be named anything like action.yaml

However, the only fix seems to be to disable Cloud Code > YAML Validate in Gemini Cloud Assist settings or to not include the word "action" in the name. I had also tried to disable validation in the Redhat YAML and that had no impact (it does not have this issue). I was able to leave that validation on (which works properly) but seems to conflict with Gemini's.

Repro step:

Install Redhat YAML Extenion and Gemini Cloud Assist Extension. Open YAML file with the word "action" in the name and the Open AI Spec (e.g. test-action.yaml) VScode reports several erorrs about unexpected properties Turn off validation in Gemini Code Assist (errors go away) Create a new YAML file with the same content as one with the errors but do not include "action" in the name. Turn on validation in Gemini Code Assist and reload window (errors come back for any files with "action" in the name).

The YAML file you use to test can be as simple as:

yaml-language-server: $schema=https://spec.openapis.org/oas/3.1/schema/2021-09-28

openapi: 3.1.0 info: title: My API version: 1.0.0 paths: {}

The cause seems to have something to do with "action" as part of the file name (which is very odd) and only fixed by changing the file name or disabling YAML validation in Gemini Cloud Assist.  

maxrandolph commented 3 weeks ago

Hi @sspage, thanks for filing the issue. Could you please repro this and then file feedback within the extension with your logs attached? Thanks!