GoogleCloudPlatform / cloud-foundation-fabric

End-to-end modular samples and landing zones toolkit for Terraform on GCP.
Apache License 2.0
1.52k stars 875 forks source link

Feature request: Add support for deployment_type in apigee module #1114

Closed blackillzone closed 1 year ago

blackillzone commented 1 year ago

Hello,

Since the provider support the deployment_type argument for Apigee environment deployments (https://github.com/hashicorp/terraform-provider-google/pull/11405), it would be a nice upcoming add for the apigee module.

In the same time, we could also add the api_proxy_type parameter.

I guess it would be something like this for the module variables:

environments = {
    apis-test = {
      display_name = "APIs test"
      description  = "APIs Test"
      deployment_type = "PROXY"
      api_proxy_type = "PROGRAMMABLE"
      envgroups    = ["test"]
    }
}

And I suppose it should be optional, with default values at null, and if null, we don't set the options in the google_apigee_environment resource.

This way, the current module should be without breaking changes.

blackillzone commented 1 year ago

Added https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1115, and waiting for the CLA to be validated.

juliocc commented 1 year ago

Fixed with #1115