Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance

GoogleCloudPlatform / cloud-foundation-fabric

End-to-end modular samples and landing zones toolkit for Terraform on GCP.

Apache License 2.0

1.54k stars 883 forks source link

Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance #2173

Closed wiktorn closed 1 week ago

wiktorn commented 7 months ago

│ Warning: Deprecated Resource
│ 
│   with module.test.google_notebooks_instance.playground,
│   on [...]/cloud-foundation-fabric/blueprints/data-solutions/vertex-mlops/vertex.tf line 82, in resource "google_notebooks_instance" "playground":
│   82: resource "google_notebooks_instance" "playground" {
│ 
│ `google_notebook_instance` is deprecated and will be removed in a future major release. Use `google_workbench_instance` instead.
│ 
│ (and one more similar warning elsewhere)

ludoo commented 2 months ago

@wiktorn shall we

keep this open and find someone to work on it?
deprecate and remove the blueprint?

I would prefer not to keep this issue open indefinitely, WDYT?

lcaggio commented 2 months ago

The same change need to be done in the Data-playground blueprint.

gioconte did a PR (to be finalized).

gioconte, can you work on fixing the 2 blueprints?

lcaggio commented 1 month ago

@gioconte , any comment?