GoogleCloudPlatform / cloud-foundation-toolkit

The Cloud Foundation toolkit provides GCP best practices as code.
Apache License 2.0
947 stars 451 forks source link

file already closed error for cli reading logs from go test #1709

Open bharathkkb opened 1 year ago

bharathkkb commented 1 year ago

An error like lvl=eror msg="error reading output: read |0: file already closed" was reported which seems to be from https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/93e84cf114487d243b2fde0a2a591ca71f5e848b/cli/bptest/run.go#L90

I think in some edge case of cmd termination there could be a synchronization issue between the logging go routine and waiting for the cmd.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days