GoogleCloudPlatform / cloud-foundation-toolkit

The Cloud Foundation toolkit provides GCP best practices as code.
Apache License 2.0
965 stars 457 forks source link

SERVICE_ACCOUNT_JSON env var typo #639

Closed linde closed 4 years ago

linde commented 4 years ago

i think the script in the docker image expects the value of the credential, not a path to it to be passed in as an environment variable.

so in 4.2 Setup Terraform Credential on (step 4) the command should be the following or something similar, i think:

export SERVICE_ACCOUNT_JSON=$(< cft.json)

and the text needs to reflect that it is the value, not the path.

morgante commented 4 years ago

Thanks, updated!