search

GoogleCloudPlatform / cloud-opensource-java

Tools for detecting and avoiding linkage errors in GCP open source projects
Apache License 2.0
152 stars 72 forks source link

Glue #1034

Open elharo opened 4 years ago

elharo commented 4 years ago

Consider whether we should adopt any parts of https://glue-docs.appspot.com/ for jlbp.dev. E.g. font choices, max width.

garrettjonesgoogle commented 4 years ago

https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1253 uses Glue

suztomo commented 4 years ago

Glue's CSS is available in CDN https://glue-docs.appspot.com/get-started/cdn/ If we use the CDN, we don't need to maintain the sass files in #1253 .

garrettjonesgoogle commented 4 years ago

The reason for the scss files in #1253 is to support extension, which is used for header tags. I have since removed the glue.scss file in #1253 , and accomplished the same effect using javascript. The PR used the CDN for glue from the beginning and still does.

suztomo commented 4 years ago

Thank you for clarification.