fix: Fix root README badges to use the main branch' results

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.

Apache License 2.0

406 stars 148 forks source link

fix: Fix root README badges to use the main branch' results #1050

Closed bourgeoisor closed 1 year ago

bourgeoisor commented 1 year ago

This PR fixes https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/issues/1051:

Makes sure that the CLI and Terraform workflows run on the main branch instead of just in PRs
Makes sure that the root README Action badges only uses the results taken from latest main commit, rather than "whichever last PR was opened / had the workflows run" which leads to a mismatch between what users think the badges mean (latest commit) and what the badges used to do (latest PR, regardless if it was even merged)

conventional-commit-lint-gcf[bot] commented 1 year ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

bourgeoisor commented 1 year ago

This PR does not affect the workflows running on PRs. Workflows still run on PRs and will now also run on the main branch.
Created an issue and linked it to this PR: https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/issues/1051

minherz commented 1 year ago

As discussed, we will remove the badge display from the README file at the root of the repo. The configuration does lot support merging directly to the main branch. The change will be applied either as a part of the next release or by a patch.