search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
405 stars 148 forks source link

[Bug]: GitHub badges on the root README do not reflect any meaningful status #1051

Closed bourgeoisor closed 11 months ago

bourgeoisor commented 1 year ago

Version of Cloud Ops Sandbox

N/A

Your client machine OS?

iOS

Tell us, what is a problem?

Currently, the badges on the root README do not show any meaningful status. They show the latest status of these workflows:

But since these workflows only runs on PRs (and not on main), the badges reflect the status of the last PR that happened to have ran those workflows (whether or not that PR has even been merged in).

What you expected to happen?

We should:

Code of Conduct

minherz commented 1 year ago

Cloud Ops Sandbox adapts the trunk-based model. In this model each release is maintained in the dedicated branch and the main branch may represent the current development status of the development on top of the latest X.Y.Z version.

The current goal for showing the status of the latest CLI and Terraform workflows was based on certain expectations for the development velocity that did not come true.

What is a goal of the request to "only show latest main run"? Limiting the aforementioned workflows to run only on PRs that submitted to the main branch prevents any development work that takes place in any other branch from being validated vs. these workflows.

minherz commented 1 year ago

It is decided that we remove the badges from the README file at the root of the repo for now. The badges will be removed no later than 0.10.0 version release