GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
405 stars 148 forks source link

feat: create `default` VPC network if it does not exist already #1052

Closed lvaylet closed 1 year ago

lvaylet commented 1 year ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

🛠️ Fixes #1043

conventional-commit-lint-gcf[bot] commented 1 year ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

lvaylet commented 1 year ago

Hi @minherz, any chance you could review this PR for milestone/0.10?

minherz commented 1 year ago

updated: This change is rolled back. The rationale behind the rollback includes:

lvaylet commented 1 year ago

Thanks for the update. I just tested this approach in a clean project with no default VPC. It does not work indeed. I was pretty sure I had tested it prior to submitting the PR. I probably did so in a project that already had a default VPC.