[Bug]: sandboxctl doesn't handle the environment variable VERSION - Githubissues

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.

Apache License 2.0

406 stars 148 forks source link

[Bug]: sandboxctl doesn't handle the environment variable VERSION #1058

Closed ymotongpoo closed 1 year ago

ymotongpoo commented 1 year ago

Version of Cloud Ops Sandbox

0.9.2

Your client machine OS?

Linux

Tell us, what is a problem?

On running sandboxctl, it fails with the following error message.

./provisioning/sandboxctl: line 214: VERSION: unbound variable

I looked up the source code, and found that the environment variable VERSION is just defined here and not initialized.

It should be SANDBOX_VERSION instead.

What you expected to happen?

sandboxctl runs without any error message because of syntax error of the bash script.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

minherz commented 1 year ago

Duplicates #1045