fix(terraform): update min_count and max_count to of min_node_count

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.

Apache License 2.0

405 stars 148 forks source link

fix(terraform): update min_count and max_count to of min_node_count #1061

Closed Ayelet41 closed 6 months ago

Ayelet41 commented 6 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Your change follows guidelines in the Contributor guide
[ ] Communicate test infrastructure changes, i.e. API enablement, secrets
[ ] Appropriate docs were updated (if necessary)

🛠️ Fixes #

minherz commented 6 months ago

min_count and max_count variables are used in gke.tf as input parameters to gke module (terraform-google-modules/kubernetes-engine/google). I am reviewing the fact that the "main" and "release/0.9" branches are out of sync. The result of this work will be a patch 0.9.4 that should address the current problem with installing 0.9.3 and synchronize the branches. If the use of gke and asm modules will be proved impossible, the changes to the relative terraform modules will be rolled back.