search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
406 stars 148 forks source link

feat: add app version to GKE cluster #788

Closed Ayelet41 closed 3 years ago

Ayelet41 commented 3 years ago

For previous version will be 0 as we don't know what is the version. For that introduced a new GKE param(could use default, but wanted to be explicit).

+Run fmt

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

github-actions[bot] commented 3 years ago

Open in Cloud Shell

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

github-actions[bot] commented 3 years ago

Open in Cloud Shell You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

daniel-sanche commented 3 years ago

It might be a good idea to add a test if you can think of one. Otherwise LGTM

Ayelet41 commented 3 years ago

Issue to add test later: https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/issues/834