search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
406 stars 148 forks source link

Terrform module for GKE, workload_pool needs to be used. #876

Closed balldarrens closed 3 years ago

balldarrens commented 3 years ago

File: https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/blob/main/terraform/03_gke_cluster.tf Lines: 55-58

Enable Workload Identity for cluster

workload_identity_config { identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" }

This causes errors due to deprecation and is stopping provisioning:

╷ │ Warning: Deprecated Attribute │ │ with google_container_cluster.gke, │ on 03_gke_cluster.tf line 57, in resource "google_container_cluster" "gke": │ 57: identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" │ │ This field will be removed in a future major release as it has been deprecated in the API. Use workload_pool instead. │ │ (and 4 more similar warnings elsewhere) ╵ ╷ │ Error: Error waiting to create StandardAppVersion: Error waiting for Creating StandardAppVersion: Error code 9, message: Cloud build b843293f-3d6b-4e99-830f-367f5fdf4244 status: FAILURE │ An unexpected error occurred. Refer to build logs: https://console.cloud.google.com/cloud-build/builds;region=us-east1/b843293f-3d6b-4e99-830f-367f5fdf4244?project=422119052187 │ Full build logs: https://console.cloud.google.com/cloud-build/builds;region=us-east1/b843293f-3d6b-4e99-830f-367f5fdf4244?project=422119052187 │ │ with module.ratingservice.google_app_engine_standard_app_version.default[0], │ on ratingservice/main.tf line 117, in resource "google_app_engine_standard_app_version" "default": │ 117: resource "google_app_engine_standard_app_version" "default" { │

balldarrens commented 3 years ago

Also need to change workload_metadata_config.... MODE is used now:

╷ │ Warning: Deprecated Attribute │ │ with google_container_cluster.gke, │ on 03_gke_cluster.tf line 96, in resource "google_container_cluster" "gke": │ 96: workload_metadata_config { │ │ Deprecated in favor of mode. │ │ (and 2 more similar warnings elsewhere) ╵ ╷ │ Error: Error waiting to create StandardAppVersion: Error waiting for Creating StandardAppVersion: Error code 9, message: Cloud build ecb45764-7bba-444d-a38b-a01a1262d099 status: FAILURE │ An unexpected error occurred. Refer to build logs: https://console.cloud.google.com/cloud-build/builds;region=us-east1/ecb45764-7bba-444d-a38b-a01a1262d099?project=872867494800 │ Full build logs: https://console.cloud.google.com/cloud-build/builds;region=us-east1/ecb45764-7bba-444d-a38b-a01a1262d099?project=872867494800 │ │ with module.ratingservice.google_app_engine_standard_app_version.default[0], │ on ratingservice/main.tf line 117, in resource "google_app_engine_standard_app_version" "default": │ 117: resource "google_app_engine_standard_app_version" "default" {

balldarrens commented 3 years ago

This looks to be in develop branch.

balldarrens commented 3 years ago

Looks to be fixed