GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
406 stars 148 forks source link

fix: CVE-2021-44228 #886

Closed minherz closed 2 years ago

minherz commented 2 years ago

upgrade log4j2 package to 2.15.0 to fix ZD CVE-2021-44228

github-actions[bot] commented 2 years ago

Open in Cloud Shell You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

minherz commented 2 years ago

Fixes #883

gplasky commented 2 years ago

Looks like a required test is failing:

File "/code/provision_test.py", line 56, in testNumberOfNode
    self.assertEqual(node_count, 4)
AssertionError: 3 != 4

From the Terraform config initial_node_count = 4but auto-scaling is also enabled, with a min_node_count = 2. I don't have access to the GCP project to verify but my hypothesis is that this test is flaky based on the autoscaling configuration. Test should probably assert that node_count >= 2.