search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
406 stars 148 forks source link

feat: upgrade Istio 1.7.1 to ASM #930

Closed daniel-sanche closed 2 years ago

daniel-sanche commented 2 years ago

Users had reported that monitoring data hasn't been showing up in Cloud Monitoring. This seems to be due to incompatibility with the out-dated Istio version being used by this project. To resolve this, I updated to use the latest version of ASM, which should be more useful for demos

github-actions[bot] commented 2 years ago

Open in Cloud Shell You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

daniel-sanche commented 2 years ago

After doing some testing, it looks like some of the improvements in this branch aren't tied to ASM. I decided to break out the work into smaller PRs (https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/pull/933, https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/pull/932, https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/pull/931), and then we can decide if upgrading to ASM still looks like a good idea from there

daniel-sanche commented 2 years ago

@mathieu-benoit Don mentioned you had ASM and terraform experience, so adding you as an optional review if you have the time. Feel free to ignore though. Thanks!

daniel-sanche commented 2 years ago

@mathieu-benoit Thanks for the feedback! I added your comments to the issue around terraform refactoring for next quarter.

And yeah, it seems the description is a bit out of date as I ended up moving some parts into other PRs, but I'll make sure to fix it before merging