GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
405 stars 148 forks source link

sre-recipes aborting on warning #935

Closed daniel-sanche closed 2 years ago

daniel-sanche commented 2 years ago

The qwiklabs team reported that an sre-recipe is throwing an error and failing to continue on one of the recipes:

Failed to run SRE Recipe recipe3: Failed to run command `kubectl set env deployment/recommendationservice MAX_RESPONSES-`: W0604 02:43:54.443477    1344 gcp.go:120] WARNING: the gcp auth plugin is deprecated in v1.22+, unavailable in v1.25+; use gcloud instead

It seems like the sandboxctl tool is picking up on the deprecation warning and treating it as an error.

Removing the lines raising a runtime error solves the problem, but that may not be the best solution. We should look into better ways to filter out warnings