search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
405 stars 148 forks source link

fix: Add billing permission validation to link to project #948

Closed yuhuayang-google closed 1 year ago

yuhuayang-google commented 2 years ago

I added a validation to first check if the user has the correct IAM role to link a billing account to a project before including those accounts for selection (or if only 1 billing account make sure the user has permission and if not, exit with the appropriate error)

This PR is to fix https://github.com/GoogleCloudPlatform/cloud-ops-sandbox/issues/917

conventional-commit-lint-gcf[bot] commented 2 years ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

minherz commented 2 years ago

@yuhuayang-google please, rename your commit to follow the convention (prefix with fix:)

minherz commented 1 year ago

Closing due the breaking changes in 0.9.0 release.