search

GoogleCloudPlatform / cloud-ops-sandbox

Cloud Operations Sandbox is an open source collection of tools that helps practitioners to learn O11y and R9y practices from Google and apply them using Cloud Operations suite of tools.
Apache License 2.0
405 stars 148 forks source link

fix(releases): release notes show commits in title #966

Closed daniel-sanche closed 1 year ago

daniel-sanche commented 2 years ago

I noticed a but in the release notes section of the make-release action. The names of the hashes in the URL didn't match the names of the environment variables set earlier. This would result in broken links in the PR description

github-actions[bot] commented 2 years ago

Open in Cloud Shell You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

minherz commented 2 years ago

@daniel-sanche the misnaming results in missing hashes in the release notes title only.

minherz commented 1 year ago

Closing due to the breaking changes in the 0.9.0 release