search

GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

sed -i does not work on macOS #116

Open averikitsch opened 4 years ago

averikitsch commented 4 years ago
  1. When using macOS with bash (domain-setup.sh), I receive an error: sed: -i may not be used with stdin. Though there is no error when using Cloud Shell (Linux).

Also, env.mk is created/edited in both domain-steup.sh and bootstrap.sh scripts.

subfuzion commented 4 years ago

Use the gnu version of sed: brew install gnu-sed and then follow instructions for putting gnubin earlier in your path so it shadows the default version that ships with macOS.

Also, you can just safely manually edit PROJECT_ID, CLUSTER_NAME, and DOMAIN yourself in env.mk if everything succeeded in the script up to that point.