GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

Adding functionality that highlights Cloud Run for Anthos Events #148

Open adamdkane opened 4 years ago

adamdkane commented 4 years ago

This PR adds functionality to the Reference Web App that leverages the newly released (to public preview) Cloud Run for Anthos Events capability.

adamdkane commented 4 years ago

/gcbrun

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 22d60ea571688d93c272c69dfaf30f373faba65c into 4f903b3c732ec3e021a25bb3ee6b112d0ff7b530 - view on LGTM.com

new alerts:

zsxking commented 4 years ago

/gcbrun

codecov[bot] commented 4 years ago

Codecov Report

Merging #148 into main will decrease coverage by 1.57%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   69.92%   68.35%   -1.58%     
==========================================
  Files          23       24       +1     
  Lines         419      455      +36     
  Branches       33       36       +3     
==========================================
+ Hits          293      311      +18     
- Misses        116      134      +18     
  Partials       10       10              
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <0.00%> (ø)
src/app/alerts/alerts.component.ts 46.87% <0.00%> (ø)
src/app/app.module.ts 95.65% <0.00%> (+0.09%) :arrow_up:
src/app/login.guard.ts 45.94% <0.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f903b3...f2089a3. Read the comment docs.

zsxking commented 4 years ago

/gcbrun

zsxking commented 4 years ago

/gcbrun