Fix e2e on cloud - Githubissues

GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.

https://cloud.google.com/anthos/run

Apache License 2.0

37 stars 22 forks source link

Fix e2e on cloud #20

Closed zsxking closed 4 years ago

zsxking commented 4 years ago

Fixed up e2e tests so that it would properly run in container and on Cloud Build.

Updated some miss-matched libraries
Fix location form to wait for submit
Disabled browser.waitForAngular() in frontend e2e test because it didn't resolve properly
Added some delay and wait to counter the lack of browser.waitForAngular()

zsxking commented 4 years ago

Unable to resolve the two complains from npm audit. Both are low level Prototype Pollution, from the same package yargs-parser. It's dependency of protractor and @angular-devkit/build-angular, both of which are at the latest stable version already.

ssmall commented 4 years ago

Created https://github.com/GoogleCloudPlatform/cloud-run-anthos-reference-web-app/issues/23 to follow up after this CL to see if we can find a better framework for e2e tests.

zsxking commented 4 years ago

It looks pretty stable now. Run it several times and it all passed fine. We can make it into presubmit test, just need to setup the project/cluster/domain to run it against. The test will include build-backend, build-frontend, and test-e2e. A challenge will be, if more than one tests are running at the same time, it could mess things up. In our current low volume of PR it will probably be fine. But if we got more ongoing PR, we will need some e2e test runner manager I think.