Closed zsxking closed 4 years ago
Unable to resolve the two complains from npm audit
. Both are low level Prototype Pollution
, from the same package yargs-parser
. It's dependency of protractor
and @angular-devkit/build-angular
, both of which are at the latest stable version already.
Created https://github.com/GoogleCloudPlatform/cloud-run-anthos-reference-web-app/issues/23 to follow up after this CL to see if we can find a better framework for e2e tests.
It looks pretty stable now. Run it several times and it all passed fine. We can make it into presubmit test, just need to setup the project/cluster/domain to run it against. The test will include build-backend
, build-frontend
, and test-e2e
. A challenge will be, if more than one tests are running at the same time, it could mess things up. In our current low volume of PR it will probably be fine. But if we got more ongoing PR, we will need some e2e test runner manager I think.
Fixed up e2e tests so that it would properly run in container and on Cloud Build.
browser.waitForAngular()
in frontend e2e test because it didn't resolve properlybrowser.waitForAngular()