GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

Fix Firebase Config setup and readme step ordering #25

Closed josueetcom closed 4 years ago

josueetcom commented 4 years ago

firebase-config-setup.sh was depending on a gcloud alpha command that doesn't currently work on Cloud Shell and doesn't seem to be generally available at the moment (even though the doc is visible).

I also reordered the two steps that referred to each other using "next step" and "previous step" so they're next to each other.

josueetcom commented 4 years ago

Honestly I'm not sure if scripts/firebase-config-setup.sh is easier than just creating that file with the project id and api key. But I'm fine with it either way.

Yeah it's probably roughly the same