search

GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

Restructure the backend directory to facilitate adding more services. #42

Closed mdivanova closed 4 years ago

josueetcom commented 4 years ago

It looks like you'll need to change these lines in the PR checks to use the new directory structure

mdivanova commented 4 years ago

How thoroughly have these changes been tested? Ideally they would be (manually) tested by setting up a fresh project, running all make commands, and then running the frontend e2e tests.

I did manually set up a fresh project on cloud shell and run all the make commands. Manual testing of the site looked good.

The frontend e2e tests are flaky though - a different number fail on different runs. The failure errors are not manually reproducible on the site (e.g. Not being able to find a "Create" button on the Items page). I don't think this is related to my refactoring. Are these reliably run by others?

ssmall commented 4 years ago

How thoroughly have these changes been tested? Ideally they would be (manually) tested by setting up a fresh project, running all make commands, and then running the frontend e2e tests.

I did manually set up a fresh project on cloud shell and run all the make commands. Manual testing of the site looked good.

The frontend e2e tests are flaky though - a different number fail on different runs. The failure errors are not manually reproducible on the site (e.g. Not being able to find a "Create" button on the Items page). I don't think this is related to my refactoring. Are these reliably run by others?

@zsxking can you comment on e2e test flakiness? Is this expected or should we be concerned that these changes broke something?

mdivanova commented 4 years ago

How thoroughly have these changes been tested? Ideally they would be (manually) tested by setting up a fresh project, running all make commands, and then running the frontend e2e tests.

I did manually set up a fresh project on cloud shell and run all the make commands. Manual testing of the site looked good. The frontend e2e tests are flaky though - a different number fail on different runs. The failure errors are not manually reproducible on the site (e.g. Not being able to find a "Create" button on the Items page). I don't think this is related to my refactoring. Are these reliably run by others?

@zsxking can you comment on e2e test flakiness? Is this expected or should we be concerned that these changes broke something?

I see the same behavior when running e2e tests on my project from last week's bugash.

zsxking commented 4 years ago

The flakiness is expected because of the arbitrary waiting. As long as it's not failing on the same test over and over again, it's probably fine.