GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

Evaluate makefile variables only at target execution time #67

Closed josueetcom closed 4 years ago

josueetcom commented 4 years ago

This makes command line makefile target tab completion much faster (50-100x or so to tab complete make clu in the command line) than before as it won't be evaluating gcloud variables defined using := or ifeq.

This was an annoying itch I decided to scratch :)

Note: The changes in env.mk.sample will need to be reflected in your personal env.mk so that the faster makefile tab completion takes effect (otherwise reading the makefile for tab completion will involve invoking three gcloud commands to get the cluster location/version and managed zone name)