Closed zsxking closed 4 years ago
Merging #88 into master will decrease coverage by
1.15%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 59.84% 58.68% -1.16%
==========================================
Files 21 22 +1
Lines 259 305 +46
Branches 24 33 +9
==========================================
+ Hits 155 179 +24
- Misses 97 116 +19
- Partials 7 10 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/app/users/users.component.ts | 53.57% <0.00%> (-21.43%) |
:arrow_down: |
src/app/login.guard.ts | 26.92% <0.00%> (-4.33%) |
:arrow_down: |
src/app/app.module.ts | 50.00% <0.00%> (ø) |
|
src/app/app-routing.module.ts | 100.00% <0.00%> (ø) |
|
src/app/firestore/firestore.service.ts | ||
src/app/allowed.directive.ts | 80.00% <0.00%> (ø) |
|
src/app/allowed.directive.mock.ts | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 61ce4d1...0c4e250. Read the comment docs.
Working on the e2e test for a separate PR. Need to sort out the part that creating users in firebase auth for the test. Don't want to wait for that on this PR.
Working on the e2e test for a separate PR. Need to sort out the part that creating users in firebase auth for the test. Don't want to wait for that on this PR.
Can you remove "Fixes #45" and "Fixes #44" from the PR description, then? We shouldn't mark the issues as closed until e2e tests are in place.
Sure. Removed