GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

User e2e test #90

Closed zsxking closed 4 years ago

zsxking commented 4 years ago

Fix #44 Fix #45

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging a53f08f9741d20080d00fe2b54931a2ef3d809ce into b1768e780b454ecd0eef51fcd7bfd7dc4adf6b51 - view on LGTM.com

new alerts:

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 11.23%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #90       +/-   ##
===========================================
+ Coverage   58.68%   69.92%   +11.23%     
===========================================
  Files          22       23        +1     
  Lines         305      419      +114     
  Branches       33       33               
===========================================
+ Hits          179      293      +114     
  Misses        116      116               
  Partials       10       10               
Impacted Files Coverage Δ
...n-dialog/inventory-transaction-dialog.component.ts
src/app/testing/dummy.component.ts
src/app/location-view/location-view.component.ts
src/app/login/login.component.ts
src/app/locations/locations.component.ts
src/app/login.guard.ts
src/environments/environment.ts
src/app/allowed.directive.mock.ts
src/app/app.component.ts
src/app/items/items.component.ts
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1768e7...0ee6931. Read the comment docs.

zsxking commented 4 years ago

The report looks wrong because I fixed the project root. The file was shown as src/app/... before. With the fix it shows as webui/src/app. But the report is not able to work with that change. But anyway I reverted all codecov related changes, as those are not related to the core of this PR and should not be blocking it.