search

GoogleCloudPlatform / cloud-run-anthos-reference-web-app

An opinionated set of best practices aimed at demonstrating a reference architecture for building a web application on Google Cloud using Cloud Run for Anthos.
https://cloud.google.com/anthos/run
Apache License 2.0
37 stars 22 forks source link

build-webui makefile target failing #91

Closed josueetcom closed 4 years ago

josueetcom commented 4 years ago

Currently make build-webui is failing due to not finding the user service client. Cloud Build gives this output:

Step #2 - "Build": ERROR in src/app/users/users.component.ts:19:35 - error TS2307: Cannot find module 'user-svc-client'.
Step #2 - "Build":
Step #2 - "Build": 19 import { UserService, User } from 'user-svc-client';
Step #2 - "Build":                                      ~~~~~~~~~~~~~~~~~
Step #2 - "Build": src/app/users/users.component.ts:43:7 - error TS7006: Parameter 'data' implicitly has an 'any' type.
Step #2 - "Build":
Step #2 - "Build": 43       data => {
Step #2 - "Build":          ~~~~
Step #2 - "Build": src/app/users/users.component.ts:48:8 - error TS7006: Parameter 'e' implicitly has an 'any' type.
Step #2 - "Build":
Step #2 - "Build": 48       (e) => {
Step #2 - "Build":           ~
Step #2 - "Build": src/app/login.guard.ts:25:29 - error TS2307: Cannot find module 'user-svc-client'.
Step #2 - "Build":
Step #2 - "Build": 25 import { UserService } from 'user-svc-client';
Step #2 - "Build":                                ~~~~~~~~~~~~~~~~~
Step #2 - "Build": src/app/app.module.ts:26:73 - error TS2307: Cannot find module 'user-svc-client'.
Step #2 - "Build":
Step #2 - "Build": 26 import { BASE_PATH as USER_BASE_PATH, ApiModule as UserApiModule } from 'user-svc-client';

This seems to be due to a missing client generation step in webui/cloudbuild.yaml for the new User Service.