GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
526 stars 91 forks source link

[Feature Request] Add configuration for Cloud Run CLI flags #108

Closed averikitsch closed 2 years ago

averikitsch commented 4 years ago

Setting flags such as max instance and memory size from the configuration json.

ahmetb commented 4 years ago

Related: was discussed a bit here https://github.com/GoogleCloudPlatform/cloud-run-button/pull/89#issuecomment-541079900

I think overall we need some property bag objects in app.json to control various aspects. Ideally, not a flat list, as that can result in gigantic objects over time as we add more flags to gcloud. So maybe some categorization of such objects can help.

jamesward commented 4 years ago

Mem & cpu options are now available via app.json See: #175

benwinding commented 3 years ago

Would also be great to have the concurrency flag too if possible!

glasnt commented 2 years ago

Many flags were added in #228; there needs to be some thought as to how to make these flags easier to add in the future; maybe directly passing through to gcloud run deploy?