[Bug] Optional arguments aren't optional

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click

https://cloud.run

Apache License 2.0

526 stars 91 forks source link

Closed andrewhowdencom closed 4 years ago

andrewhowdencom commented 4 years ago

Hola crew,

While deploying:

I encountered a problem in which the application attempted to parse the options but, as they are missing in app.json parsed a nil and SIGSEGV`'d.

The following PR is designed to fixed it:

But I think the actual bug is in this application.

jamesward commented 4 years ago

Whoops! Hit by the billion dollar bug :)

I’ll get this fixed this afternoon.

jamesward commented 4 years ago

This bug was fixed by #127

But we do need to get a new version deployed. I'll request that now.

andrewhowdencom commented 4 years ago

No worries! No rush from my side; I just patched the repo with the button I liked.

jamesward commented 4 years ago

This fix has been deployed. Sorry that took so long! Feel free to re-open if you are still having issues. Thanks!