GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
527 stars 92 forks source link

add github workflows for CI #136

Closed ahmetb closed 4 years ago

ahmetb commented 4 years ago

two jobs:

ahmetb commented 4 years ago

Not sure why they're not running in this PR. Maybe it'll run after this one is merged. 🤷‍♂ They run on my fork.

ahmetb commented 4 years ago

example: https://github.com/ahmetb/cloud-run-button/commit/ea60a56b49056e9328a1e4c973dbde54b4d12dec/checks?check_suite_id=405341392

jamesward commented 4 years ago

Cool! Is there any way to link this to our Cloud Build process so that we fail the image creation if these tests don't pass? That'd help prevent us from rolling out failed images.

ahmetb commented 4 years ago

That would require bringing google secrets to GitHub which is not desirable. This should cover decent ground since it does a Docker Build. If that’s passing, cloudbuild is likely to pass (and vice versa).

ahmetb commented 4 years ago

Looks like the first build kicked off https://github.com/GoogleCloudPlatform/cloud-run-button/commit/0d1419d69a82454717a9799fc054b8c710509826/checks?check_suite_id=406604832