Closed ahmetb closed 4 years ago
Not sure why they're not running in this PR. Maybe it'll run after this one is merged. 🤷‍♂ They run on my fork.
Cool! Is there any way to link this to our Cloud Build process so that we fail the image creation if these tests don't pass? That'd help prevent us from rolling out failed images.
That would require bringing google secrets to GitHub which is not desirable. This should cover decent ground since it does a Docker Build. If that’s passing, cloudbuild is likely to pass (and vice versa).
Looks like the first build kicked off https://github.com/GoogleCloudPlatform/cloud-run-button/commit/0d1419d69a82454717a9799fc054b8c710509826/checks?check_suite_id=406604832
two jobs:
cloudshell_open: run tests, build an image (takes long b/c cloudshell base image is quite large)
redirector: run unit tests, build image