Closed jamesward closed 4 years ago
Consider having fixes #xxx
in the commit/PR message (not title) so github can auto-close :)
Consider having
fixes #xxx
in the commit/PR message (not title) so github can auto-close :)
It just needs to be in the first commit (which it was). The PR picked the title from the first commit.
I've cleaned this up to your suggestion.
Awesome, thanks! The CI will take ~forever. Feel free to merge yourself.
Thanks for your Go styling help :)
strings.Split on an empty string returns a slice of length 1 containing an empty string. We need to detect this and return a new slice of length 0.