search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
527 stars 92 forks source link

Handle No Projects Correctly - fixes #138 #139

Closed jamesward closed 4 years ago

jamesward commented 4 years ago

strings.Split on an empty string returns a slice of length 1 containing an empty string. We need to detect this and return a new slice of length 0.

ahmetb commented 4 years ago

Consider having fixes #xxx in the commit/PR message (not title) so github can auto-close :)

jamesward commented 4 years ago

Consider having fixes #xxx in the commit/PR message (not title) so github can auto-close :)

It just needs to be in the first commit (which it was). The PR picked the title from the first commit.

I've cleaned this up to your suggestion.

ahmetb commented 4 years ago

Awesome, thanks! The CI will take ~forever. Feel free to merge yourself.

jamesward commented 4 years ago

Thanks for your Go styling help :)