Move away from gcloud usages with client libraries

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click

https://cloud.run

Apache License 2.0

526 stars 91 forks source link

Move away from gcloud usages with client libraries #149

Closed ahmetb closed 4 years ago

ahmetb commented 4 years ago

Some massive refactoring for phasing out gcloud usages.

Most things are simple, but I had to reimplement gcloud run deploy which turned out to be the most complicated (expecting potential bugs on redeploying existing services as it's a different code path).

Also the trusted shell detection can now easily be done using TRUSTED_ENVIRONMENT=true, so removing "organizations list" command call.

Fixes #145.

ahmetb commented 4 years ago

Will rebase.

jamesward commented 4 years ago

Ran this through my terrible integration tests: https://github.com/jamesward/cloud-run-button-jamesward/commit/a2ff4a229c6411a81bb88ed5f87bbc62bc480dec

And it passed. So LGTM.