GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
525 stars 91 forks source link

add pause period to readiness check #173

Closed ahmetb closed 4 years ago

ahmetb commented 4 years ago

Currently we probably are hammering the api during the 4 minute period non-stop as quick as the GetService returns. This might cause users to potentially hit a rate limit error (causing run-button to fail itself).

So adding a 2 second time period to cool things down. Since it corresponds to max 120 calls over 240 secs it should be ok for now.

cc: @jamesward