GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
523 stars 91 forks source link

Use Public Image Instead of Building One #181

Open jamesward opened 4 years ago

jamesward commented 4 years ago

If a project publishes a public container image then maybe the button should allow the skipping the build and just using the existing image. Via app.json like:

{
    "build": {
        "skip": false
    },
    "override": {
        "image": "gcr.io/cloudrun/hello"
    }
}

Not sure if this is a good idea or not.

ahmetb commented 4 years ago

This basically makes the project an alternative to deploying directly from Cloud Run console. Similarly, broadens the focus from "deploy repos" to "deploy images or repos".

jamesward commented 4 years ago

Yeah, maybe if https://console.cloud.google.com/run/create had a way to specify some default params (image, service name, allow-unauthenticated, etc) then that'd be a better way to go. Still would be missing env var handling though.