No Busy Spinner on Build

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click

https://cloud.run

Apache License 2.0

528 stars 92 forks source link

No Busy Spinner on Build #182

Closed jamesward closed 4 years ago

jamesward commented 4 years ago

I think the busy indicator used to spin during the build but it doesn't anymore. Might be something I broke.

ahmetb commented 4 years ago

Found the issue. It's because we're calling actual build job before starting the spinner. So it does show the spinner momentarily, but only after the build is completed. :)

jamesward commented 4 years ago

ah. I'm pretty sure i broke that :(