search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
525 stars 91 forks source link

Docker Command Wrong #186

Closed jamesward closed 4 years ago

jamesward commented 4 years ago

When doing a docker build, the command listed is:

docker build --tag gcr.io/blah/asdf .

But since the project is in a subdir, that command doesn't work if the user copy & pastes it. Maybe it'd work to just change the listed command to:

docker build --tag gcr.io/blah/asdf asdf
ahmetb commented 4 years ago

That’s a good point. Feel free to do a PR.