search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
525 stars 91 forks source link

Maybe Use GC Load Balancer on Redirector #194

Open jamesward opened 4 years ago

jamesward commented 4 years ago

Why? Cool example of doing global load balancing and location based serving.

Could also either auto-select the region or change the default based on where the user is.

ahmetb commented 4 years ago

Probably harder for long-term maintenance (thinking of people who’d come after me) until there’s a native support for doing so with 1-command or something similar.

But the auto-select region argument is brilliant. It would work.

jamesward commented 4 years ago

We do have deployment automated already: https://github.com/GoogleCloudPlatform/cloud-run-button/blob/master/cloudbuild-redirector.yaml

So we could possibly add all the setup / deployment there.

ahmetb commented 4 years ago

It’s more of "ensuring 7-8 load balancer are there" could be the difficult part. Something along the lines of Terraform can do this probably better. Similarly when you create a LB you'd need to deal with static IP management world and accidentally not deleting that, whereas it's hard to break Cloud Run domain mappings.