search

GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
525 stars 91 forks source link

Redirector With Explicit git_url From GitHub Loses Param #197

Closed jamesward closed 3 years ago

jamesward commented 3 years ago

I have a repo that hard codes the git_repo and revision params in the button: https://github.com/jamesward/hello-java/tree/jdk15

But the redirector gets confused because it sees the referer as https://github.com and so it asks the user to still specify the repo.

ahmetb commented 3 years ago

I am OOO but can review a patch if you create. Should be as easy as fixing the if stmt.

jamesward commented 3 years ago

Thanks! Here is the PR: https://github.com/GoogleCloudPlatform/cloud-run-button/pull/199