GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
525 stars 91 forks source link

provide env ordering via "order" key #209

Closed ahmetb closed 3 years ago

ahmetb commented 3 years ago

Introducing an optional "order" key to the env object.

The sorting takes a look at if "order" field is specified or not. If not, the key is prompted last. If specified, it sorts them by the value of the "order" field.

The order is still non-deterministic if env objects don't specify an "order" value. (i.e. this patch still doesn't preserve map order).

Fixes #205. cc: @jamesward

jamesward commented 3 years ago

Awesome! Thank you.