add configuration for pack build - fixes #215

cage1016 commented 3 years ago

Add environment variables that are set at build time for build pack according to GoogleCloudPlatform/buildpacks: Builders and buildpacks designed to run on Google Cloud's container platforms

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

cage1016 commented 3 years ago

@googlebot I signed it!

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cage1016 commented 3 years ago

https://github.com/GoogleCloudPlatform/cloud-run-button/pull/216/checks?check_run_id=2158196044#step:9:344

failed to register layer: Error processing tar file(exit status 1): write /google/gopath/src/github.com/go-delve/delve/.git/objects/pack/pack-3f079e785f41218b943c0cb7b51afd55e4791e95.pack: no space left on device
Error: Process completed with exit code 1.

jamesward commented 3 years ago

Thanks for putting this together and sorry I forgot to respond to your issue. I think that generally we should probably have users rely on the buildpack mechanisms for this instead of creating another way to do this. Specifically for build env vars, you can include a project.toml file that has the build env vars, like: https://github.com/GoogleCloudPlatform/buildpack-samples/blob/master/sample-functions-framework-go/project.toml

Does that approach work for you what you need?

cage1016 commented 3 years ago

@jamesward

Thanks for your reply (Actually, i don't know I could pass env at that way with Gloud Run button). It works as I want. Cause i need to pass through few envs at build time. I will close this pull request.

jamesward commented 3 years ago

Cool. I'll reopen this to add a link to the buildpack docs so that this method is more discoverable.

jamesward commented 3 years ago

Oh, actually will just leave your other issue open and add a comment there.

cage1016 commented 3 years ago

Thanks a lot :-)

GoogleCloudPlatform / cloud-run-button