GoogleCloudPlatform / cloud-run-button

Let anyone deploy your GitHub repos to Google Cloud Run with a single click
https://cloud.run
Apache License 2.0
523 stars 91 forks source link

Add max-instances and concurrency options #228

Closed glasnt closed 2 years ago

glasnt commented 2 years ago

Only adds options if defined by user (otherwise doesn't pass a default value, allowing downstream systems to specify)

Resolves #227

Addresses request in #108, but doesn't scale the solution as suggested.

Tested in isolation, pending automated testing

jamesward commented 2 years ago

Thanks! This looks good to me. Unfortunately we don't have any automated integration tests. So I'll let you merge this after when you are ready / feel good with sufficient manual testing.